Add support for > 64 IRQs #7
Conversation
There was a problem hiding this comment.
Thanks for your interest in contributing @wizard97
Please note that for a contribution to be considered, its commits need to be signed off:
https://github.com/BabbleSim/native_simulator?tab=readme-ov-file#developer-certification-of-origin-dco
Why do you want to change this?
The content of native/src is optional, and if you want more than 64 interrupts I presume you have other HW models(?). In which case you may as well just have a different interrupt controller provided from your code. See for ex. how the nRF HW models include their own evolution of this irq_controller which supports N interrupts and M irq controller instances: https://github.com/BabbleSim/ext_nRF_hw_models/blob/main/src/HW_models/irq_ctrl.c
Signed-off-by: Aaron Wisner <[email protected]>
|
Thanks for the cool project! I'm interested in upstreaming some fixes (more to come) that might benefit other users.
All set! Amended the commit with the signature.
I guess what I am missing is why one would want to have to fork core peripherals (e.g. timer, irq controller) if from an API and behavioral perspective they are the same? The models in I'm actually curious why
Yes indeed, but we are still leveraging these core models in |
Updating
irq_ctrlto support greater than 64 IRQs. Also allows user to setN_IRQSdefine that overrides the default of 32.Basically just switch from
uint64_t irq_statustouint64_t irq_status[].